ENH: Use Release CMAKE_BUILD_TYPE for macOS Python CI builds#87
Closed
thewtex wants to merge 1 commit intoInsightSoftwareConsortium:python-buildsfrom
Closed
ENH: Use Release CMAKE_BUILD_TYPE for macOS Python CI builds#87thewtex wants to merge 1 commit intoInsightSoftwareConsortium:python-buildsfrom
thewtex wants to merge 1 commit intoInsightSoftwareConsortium:python-buildsfrom
Conversation
hjmjohnson
approved these changes
Nov 5, 2018
Member
|
@thewtex NOTE: Mac build is failing. |
dzenanz
reviewed
Nov 5, 2018
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Was PythonGetNameOfClass the only test which was failing with MinSizeRel?
Member
Author
|
Changing from E.g. https://open.cdash.org/viewTest.php?onlyfailed&buildid=5614687
|
Member
Author
|
Merging into |
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the CONTRIBUTING guide. Specifically:
Start ITK commit messages with a standard prefix (and a space):
Provide a short, meaningful message that describes the change you made.
When the PR is based on a single commit, the commit message is usually left as the PR message.
A reference to a related issue or pull request in your repository. You can automatically close a related issues using keywords
@mentions of the person or team responsible for reviewing proposed changes.
Thanks for contributing to ITK!